tests: Bluetooth: Mesh: remove key ID distribution in mesh bsim #85069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
Andrewpini,
HaavardRei,
KyraLengfeld,
LingaoM,
PavelVPV,
akredalen,
jhedberg and
omkar3141
jhedberg
reviewed
Feb 3, 2025
omkar3141
previously approved these changes
Feb 3, 2025
Contributor
omkar3141
left a comment
omkar3141
left a comment
There was a problem hiding this comment.
Looks good to me as discussed.
tomi-font
reviewed
Feb 4, 2025
Contributor
Author
|
Seems there are already some ranges allocated without any centralized header\document and etc in Zephyr. |
Contributor
|
Superseded by #85581. |
Contributor
Author
Hi @tomi-font, mostly yes. However, mesh requires some cleaning up due to your changes. I'll wait until your PR is merged and then rebase and continue cleaning changes here. |
Commit removes centralized PSA key ID distribution in mesh bsim tests since secure storage is instantiated on every simulated device. Signed-off-by: Aleksandr Khromykh <[email protected]>
Commit removes weak attribute and renames some functions in crypto_psa.c since there is no centralized distribution of the PSA key ID in bsim tests and no necessity to reimplement native mesh approach. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
change_mesh_psa_id_range
branch
from
43c14cb to
c466797
Compare
alxelax
changed the title
omkar3141
approved these changes
Feb 14, 2025
PavelVPV
reviewed
Feb 17, 2025
PavelVPV
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: